Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the workflow run fail if any job fails, but remaining matrix configurations run if one matrix configuration fails. #627

Merged
merged 3 commits into from
May 4, 2021

Conversation

wyk9787
Copy link
Contributor

@wyk9787 wyk9787 commented Apr 29, 2021

Fixes #625

  • Workflow run fails if any job fails: continue-on-error = false (link)
  • Remaining matrix configurations keep running if one matrix configuration fails: fail-fast = false (link)

TESTED: Intentionally fail Go Tip on macOS https://github.com/wyk9787/pprof/actions/runs/797094911

@wyk9787
Copy link
Contributor Author

wyk9787 commented Apr 29, 2021

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #627 (765a159) into master (a266312) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          39       39           
  Lines        7246     7246           
=======================================
  Hits         4859     4859           
  Misses       1950     1950           
  Partials      437      437           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a266312...765a159. Read the comment docs.

@wyk9787
Copy link
Contributor Author

wyk9787 commented May 3, 2021

Gentle ping @nolanmar511

@wyk9787 wyk9787 merged commit 3a04a4d into google:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Action should notify the team if any tests failed during the cron job.
3 participants