Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add link to download profile to the UI #634

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

sandangel
Copy link
Contributor

@sandangel sandangel commented May 29, 2021

image

Updated this PR #617 with the style for the link

@google-cla google-cla bot added the cla: yes label May 29, 2021
@sandangel sandangel changed the title feat: add link to download profile to the UI feat(ui): add link to download profile to the UI May 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2021

Codecov Report

Merging #634 (1805ad4) into master (923b5ab) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   67.30%   67.28%   -0.02%     
==========================================
  Files          40       40              
  Lines        7297     7309      +12     
==========================================
+ Hits         4911     4918       +7     
- Misses       1949     1953       +4     
- Partials      437      438       +1     
Impacted Files Coverage Δ
...c/github.com/google/pprof/internal/driver/webui.go 52.15% <0.00%> (-1.36%) ⬇️
...github.com/google/pprof/internal/driver/webhtml.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923b5ab...1805ad4. Read the comment docs.

@aalexand aalexand merged commit 01bbb19 into google:master Jun 1, 2021
@sandangel sandangel deleted the feat/add-link-to-download branch June 2, 2021 03:14
rayfordj pushed a commit to migtools/pprof that referenced this pull request Jun 28, 2021
* feat: add link to download profile to the UI

* use space

* use space

* add semicolon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants