Refactor the matching of ELF program headers with profile mappings. #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed ProgramHeadersForMapping to get in a slice of program headers instead of an elf.File object. Moved the logic for matching headers by file offset to the elfexec package. Removed testelf package, as it didn't have that much reuse. Instead, defined the relevant test headers in the individual test files. Other refactoring inside binutils to simplify code. No functional changes.
aalexand
approved these changes
Jun 9, 2021
rayfordj
pushed a commit
to migtools/pprof
that referenced
this pull request
Jun 28, 2021
…oogle#635) Changed ProgramHeadersForMapping to get in a slice of program headers instead of an elf.File object. Moved the logic for matching headers by file offset to the elfexec package. Removed testelf package, as it didn't have that much reuse. Instead, defined the relevant test headers in the individual test files. Other refactoring inside binutils to simplify code. No functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed ProgramHeadersForMapping to get in a slice of program headers instead of
an elf.File object.
Moved the logic for matching headers by file offset to the elfexec package.
Removed testelf package, as it didn't have that much reuse. Instead, defined the
relevant test headers in the individual test files.
Other refactoring inside binutils to simplify code.
No functional changes.