Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Start signing com.google.prefab:cli:2.0.0 artifacts #157

Open
liutikas opened this issue Jul 15, 2022 · 3 comments
Open

[BUG] Start signing com.google.prefab:cli:2.0.0 artifacts #157

liutikas opened this issue Jul 15, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@liutikas
Copy link

com.google.prefab:cli:2.0.0 artifacts in gmaven are currently not signed (missing .asc artifacts), which makes it not possible to verify if prefab was actually build by Google or not. A large number of libraries and build tools in maven already sign their artifacts, it would be great to see prefab do the same to allow signature validation when using it.
@liutikas liutikas added the bug Something isn't working label Jul 15, 2022
@DanAlbert DanAlbert self-assigned this Jul 15, 2022
@DanAlbert
Copy link
Member

Sounds like https://docs.gradle.org/current/userguide/signing_plugin.html is the way to do the actual signing, and https://cloud.google.com/build/docs/securing-builds/use-secrets seems to be the correct way to hide the secrets.

@DanAlbert DanAlbert removed their assignment Oct 11, 2022
@liutikas
Copy link
Author

Any updates here?

@DanAlbert
Copy link
Member

It's not currently being worked on.

DanAlbert added a commit to DanAlbert/prefab that referenced this issue Feb 16, 2024
@DanAlbert
Enable signing for published artifacts.
94273f3 
This is not enabled for the CI builds yet since CI hasn't been
configured with secrets yet.

google#157
@DanAlbert DanAlbert mentioned this issue Feb 16, 2024
Merged
DanAlbert added a commit to DanAlbert/prefab that referenced this issue Feb 20, 2024
@DanAlbert
Enable signing for published artifacts.
8f68758 
This is not enabled for the CI builds yet since CI hasn't been
configured with secrets yet.

google#157
DanAlbert added a commit that referenced this issue Feb 20, 2024
@DanAlbert
Enable signing for published artifacts.
176f5b1 
This is not enabled for the CI builds yet since CI hasn't been
configured with secrets yet.

#157
DanAlbert added a commit to DanAlbert/prefab that referenced this issue Feb 20, 2024
@DanAlbert
Sign release and post-submit builds.
2b515b6 
DO NOT SUBMIT: Also signing PR builds just so I can test the workflow.
Will revert that part before merging.

Fixes google#157.
@DanAlbert DanAlbert mentioned this issue Feb 20, 2024
Closed
@DanAlbert DanAlbert added enhancement New feature or request and removed bug Something isn't working labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Prefab 2.2.0
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sign release and post-submit builds. DanAlbert/prefab
2 participants
@DanAlbert @liutikas