-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Start signing com.google.prefab:cli:2.0.0 artifacts #157
Labels
enhancement
New feature or request
Comments
Sounds like https://docs.gradle.org/current/userguide/signing_plugin.html is the way to do the actual signing, and https://cloud.google.com/build/docs/securing-builds/use-secrets seems to be the correct way to hide the secrets. |
Any updates here? |
It's not currently being worked on. |
DanAlbert
added a commit
to DanAlbert/prefab
that referenced
this issue
Feb 16, 2024
This is not enabled for the CI builds yet since CI hasn't been configured with secrets yet. google#157
DanAlbert
added a commit
to DanAlbert/prefab
that referenced
this issue
Feb 20, 2024
This is not enabled for the CI builds yet since CI hasn't been configured with secrets yet. google#157
DanAlbert
added a commit
that referenced
this issue
Feb 20, 2024
This is not enabled for the CI builds yet since CI hasn't been configured with secrets yet. #157
DanAlbert
added a commit
to DanAlbert/prefab
that referenced
this issue
Feb 20, 2024
DO NOT SUBMIT: Also signing PR builds just so I can test the workflow. Will revert that part before merging. Fixes google#157.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
com.google.prefab:cli:2.0.0 artifacts in gmaven are currently not signed (missing .asc artifacts), which makes it not possible to verify if prefab was actually build by Google or not. A large number of libraries and build tools in maven already sign their artifacts, it would be great to see prefab do the same to allow signature validation when using it.
The text was updated successfully, but these errors were encountered: