Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Any" #22

Closed
judah opened this issue Jul 9, 2016 · 0 comments
Closed

Support "Any" #22

judah opened this issue Jul 9, 2016 · 0 comments

Comments

@judah
Copy link
Collaborator

judah commented Jul 9, 2016

We should support the Any type that was introduced in proto3:
https://developers.google.com/protocol-buffers/docs/proto3#any

At its core, Any is just another protocol buffer message (defined in google/protobuf/any.proto), so we should already be able to handle protos that reference it. However, we can add a nicer API on top for converting to/from an arbitrary message type, siimilar to what the C++ and Java bindings provide.

judah added a commit to judah/proto-lens that referenced this issue Jul 12, 2017
Fixes google#22.

Provides simple `pack` and `unpack` functions.  Since the `unpack` operation
is partial (and has multiple types of "failure"), I wasn't sure how to fit it
into a `Lens`; so I left that alone for the time being.

I turned this into a minor version bump.  It does add a new field to
`MessageDescriptor` which usually requires a major bump; but since that field
is internal to codegen, it shouldn't break any individual users.
judah added a commit to judah/proto-lens that referenced this issue Jul 13, 2017
Fixes google#22.

Provides simple `pack` and `unpack` functions.  Since the `unpack` operation
is partial (and has multiple types of "failure"), I wasn't sure how to fit it
into a `Lens`; so I left that alone for the time being.

I turned this into a minor version bump.  It does add a new field to
`MessageDescriptor` which usually requires a major bump; but since that field
is internal to codegen, it shouldn't break any individual users.
@judah judah closed this as completed in #88 Jul 14, 2017
judah added a commit that referenced this issue Jul 14, 2017
Fixes #22.

Provides simple `pack` and `unpack` functions.  Since the `unpack` operation
is partial (and has multiple types of "failure"), I wasn't sure how to fit it
into a `Lens`; so I left that alone for the time being.

I turned this into a minor version bump.  It does add a new field to
`MessageDescriptor` which usually requires a major bump; but since that field
is internal to codegen, it shouldn't break any individual users.
blackgnezdo added a commit that referenced this issue Aug 17, 2018
avdv pushed a commit to avdv/proto-lens that referenced this issue Aug 9, 2023
Fixes google#22.

Provides simple `pack` and `unpack` functions.  Since the `unpack` operation
is partial (and has multiple types of "failure"), I wasn't sure how to fit it
into a `Lens`; so I left that alone for the time being.

I turned this into a minor version bump.  It does add a new field to
`MessageDescriptor` which usually requires a major bump; but since that field
is internal to codegen, it shouldn't break any individual users.
ylecornec pushed a commit to ylecornec/proto-lens that referenced this issue Feb 19, 2024
Fixes google#22.

Provides simple `pack` and `unpack` functions.  Since the `unpack` operation
is partial (and has multiple types of "failure"), I wasn't sure how to fit it
into a `Lens`; so I left that alone for the time being.

I turned this into a minor version bump.  It does add a new field to
`MessageDescriptor` which usually requires a major bump; but since that field
is internal to codegen, it shouldn't break any individual users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant