Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support enum aliases #23

Closed
judah opened this issue Jul 9, 2016 · 1 comment
Closed

Support enum aliases #23

judah opened this issue Jul 9, 2016 · 1 comment
Assignees
@judah

Comments

@judah
Copy link
Collaborator

judah commented Jul 9, 2016

Enums can have "aliases" where two different constructors may map to the same int value. (In both proto2 and proto3). This breaks our codegen, in particular the fromEnum instances.

Documentation:
https://developers.google.com/protocol-buffers/docs/proto3#enum

The user enables this feature by adding option allow_alias = true to the enum declaration. I don't know whether the protobuf compiler is the one doing the checking, or if our proto-lens-protoc plugin needs check it manually.
@judah judah self-assigned this Jul 13, 2016
@judah
Copy link
Collaborator Author

judah commented Jul 19, 2016

Fixed by #30.

@judah judah closed this as completed Jul 19, 2016
blackgnezdo pushed a commit that referenced this issue Aug 17, 2018
@silky @fkm3
test case to show can't calculate grad for embedding (and associated …
69fdbf6 
…fix) (#23)

* Fix for embedding gradient calculation

- Passes vectors instead of scalars to slice
- converts the numRows to a scalar
- add `toScalar` utility function
- minor change to test case so that it actually works

* added lib for testing helper functions

* add flatSlice function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judah judah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@judah