Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showMessage and related functions use Haskell not C string escaping conventions #45

Closed
mikegunter opened this issue Sep 8, 2016 · 2 comments
Closed

showMessage and related functions use Haskell not C string escaping conventions #45

mikegunter opened this issue Sep 8, 2016 · 2 comments

Comments

@mikegunter
Copy link

showMessage and the related pprintMessage and showMessageShort functions use the Haskell string escaping conventions instead of the C ones. This means that non-printing characters get written as, e.g. "\SOH", which https://github.com/google/protobuf/blob/master/src/google/protobuf/io/tokenizer.cc#L1039 won't parse. Worse, in Haskell the escape "\101" means decimal 101 whereas the tokenizer.cc code (following C convention) interprets that as octal, i.e. decimal 97.
@mikegunter
Copy link
Author

I have a fix in the works.

@mikegunter mikegunter mentioned this issue Sep 9, 2016
Closed
mikegunter pushed a commit to mikegunter/proto-lens that referenced this issue Sep 9, 2016
Fix Issue google#45 by using \x escapes for non-printing characters.
2a260b7 
Add tests.
mikegunter pushed a commit to mikegunter/proto-lens that referenced this issue Sep 14, 2016
Fix Issues google#20, google#40, and google#45 by using the same esca…
eb61db5 
…ping as Protobuf distribution

The Unicode escaping that the Protocol Buffer distribution supports is
not implemented for now.

Add tests.
judah pushed a commit that referenced this issue Sep 15, 2016
@judah
Fix Issues #20, #40, and #45 by using the same escaping as Protobuf d… (
093d3a5 
#48)

* Fix Issues #20, #40, and #45 by using the same escaping as Protobuf distribution

The Unicode escaping that the Protocol Buffer distribution supports is
not implemented for now.

Add tests.
@mikegunter mikegunter mentioned this issue Sep 20, 2016
Merged
@mikegunter
Copy link
Author

Fixed by #46.

blackgnezdo added a commit that referenced this issue Aug 17, 2018
@blackgnezdo @judah
Add stack resolver version switch (#38). (#45)
455e5a8 
The script can now be run with, e.g.
`env STACK_RESOLVER=lts-7.3 ci_build/outer_launch_tests.sh`
and will use the specified version of the resolver.

We can't quite enable this for lts-7.3 as the code is not pedantically
clean. We will reconsider when 8.0.2 is available which removes
`-Wredundant-constraints` from `-Wall`.
ylecornec pushed a commit to ylecornec/proto-lens that referenced this issue Feb 19, 2024
@judah
Fix Issues google#20, google#40, and google#45 by using the same esca…
a2b6060 
…ping as Protobuf d… (google#48)

* Fix Issues google#20, google#40, and google#45 by using the same escaping as Protobuf distribution

The Unicode escaping that the Protocol Buffer distribution supports is
not implemented for now.

Add tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikegunter