Hide the constructors and raw record fields of message types. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're not that useful for constructing values (especially after adding the "unknown fields" case) and were previously mostly used for documentation. Now that google#172 has landed, we have a better source of documentation that doesn't expose internal details. Also change the `Show` instance for messages to be a wrapper around `showMessageShort`. This both hides the now-inaccessible record fields and shortens the output in most cases. For example: ``` > print (def :: DescriptorProto) {} > print (def & #name .~ "hello" & #field .~ [def, def & #name .~ "bye"]:: DescriptorProto) {name: "hello" field { } field { name: "bye" }} ``` Also bump the resolver for bootstrapping to match the regular build. Hide message constructors. showsPrec, and bootstrap
blackgnezdo
approved these changes
Jan 30, 2018
| @@ -1,4 +1,4 @@ | |||
| resolver: lts-9.21 | |||
| resolver: lts-10.3 | |||
There was a problem hiding this comment.
Does this foreclose any bootstrap options?
There was a problem hiding this comment.
Not really; as long as we keep testing the older LTS's in TravisCI, we'll be reasonable sure it's possible to bootstrap with older versions by manually editing this file. I think it's just more convenient for developers if this is in sync with stack.yaml.
|
Unfortunately this causes problems related to #167; since the types don't have exposed constructors, users can't derive their own instances for them. For example: https://travis-ci.org/google/proto-lens/jobs/335018254 Leaving open for now while I try to think of a workaround. |
blackgnezdo
pushed a commit
that referenced
this pull request
Aug 17, 2018
This was referenced Aug 21, 2018
avdv
pushed a commit
to avdv/proto-lens
that referenced
this pull request
Aug 9, 2023
…#174) Finishes google#158. They're not that useful for constructing values (especially after adding the "unknown fields" case) and were previously mostly used for documentation. Now that google#172 has landed, we have a better source of documentation that doesn't expose internal details. Also change the `Show` instance for messages to be a wrapper around `showMessageShort`. This both hides the now-inaccessible record fields and shortens the output in most cases. For example: ``` > print (def :: DescriptorProto) {} > print (def & #name .~ "hello" & #field .~ [def, def & #name .~ "bye"]:: DescriptorProto) {name: "hello" field { } field { name: "bye" }} ``` Also bump the resolver for bootstrapping to match the regular build.
ylecornec
pushed a commit
to ylecornec/proto-lens
that referenced
this pull request
Feb 19, 2024
…#174) Finishes google#158. They're not that useful for constructing values (especially after adding the "unknown fields" case) and were previously mostly used for documentation. Now that google#172 has landed, we have a better source of documentation that doesn't expose internal details. Also change the `Show` instance for messages to be a wrapper around `showMessageShort`. This both hides the now-inaccessible record fields and shortens the output in most cases. For example: ``` > print (def :: DescriptorProto) {} > print (def & #name .~ "hello" & #field .~ [def, def & #name .~ "bye"]:: DescriptorProto) {name: "hello" field { } field { name: "bye" }} ``` Also bump the resolver for bootstrapping to match the regular build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're not that useful for constructing values (especially after adding the
"unknown fields" case) and were previously mostly used for documentation. Now
that #172 has landed, we have a better source of documentation that doesn't
expose internal details.
Also change the
Showinstance for messages to be a wrapper aroundshowMessageShort. This both hides the now-inaccessible record fields andshortens the output in most cases. For example:
Also bump the resolver for bootstrapping to match the regular build.
Hide message constructors.
showsPrec, and bootstrap
This change is