Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up version bounds, with for support ghc 9.8 #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Apr 6, 2024

proto-lens and proto-lens-runtime are compatible with

  • base 4.19 (ghc 9.8.2 comes with 4.19.1.0)
  • bytestring 0.12 (ghc 9.8.2 comes with 0.12.1.0)
  • containers 0.7
  • deepseq 1.5 (ghc 9.8.2 comes with 1.5.0.0)
  • ghc-prim 0.11 (ghc 9.8.2 comes with 0.11.0)
  • primitive 0.9

Closes #459.
Closes #461.

`proto-lens` and `proto-lens-runtime` are compatible with

* `base` 4.19 (ghc 9.8.2 comes with 4.19.1.0)
* `bytestring` 0.12 (ghc 9.8.2 comes with 0.12.1.0)
* `containers` 0.7
* `deepseq` 1.5 (ghc 9.8.2 comes with 1.5.0.0)
* `ghc-prim` 0.11 (ghc 9.8.2 comes with 0.11.0)
* `primitive` 0.9

Closes google#459.
Closes google#461.
Copy link

google-cla bot commented Apr 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@edsko
Copy link
Contributor Author

edsko commented Apr 6, 2024

This depends on google/ghc-source-gen#113 being released to Hackage. It builds when adding a source-repository-package to cabal.project with

source-repository-package
  type: git
  location: https://github.com/google/ghc-source-gen
  tag: d9707003aa9e922afc08c4f2b19d550c8dd344d3

@edsko
Copy link
Contributor Author

edsko commented Apr 6, 2024

Did the CLA thing, but this will still fail (I think) because it still depends on the ghc-sourc-gen release.

@blackgnezdo
Copy link
Collaborator

Could you also grab the package.yaml changes from https://github.com/blackgnezdo/proto-lens/tree/ghc98?

@blackgnezdo blackgnezdo mentioned this pull request Apr 7, 2024
@blackgnezdo blackgnezdo self-requested a review April 7, 2024 18:53
Copy link
Collaborator

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull in blackgnezdo:ghc98

@blackgnezdo
Copy link
Collaborator

Let's merge #467 instead as it covers everything we need for the release. Thanks for sending the original change and giving me impulse to finish this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump upper bounds for base, containers, ghc-prim, primitive Support deepseq-1.5 and bytestring-0.12
2 participants