Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assumption of 'proto' subdir is too restrictive #1

Closed
louiscryan opened this issue Apr 14, 2015 · 0 comments · Fixed by #2
Closed

Assumption of 'proto' subdir is too restrictive #1

louiscryan opened this issue Apr 14, 2015 · 0 comments · Fixed by #2

Comments

@louiscryan
Copy link

Plugin assumes proto files are contained in a directory called 'proto' under src/main. This is quite restrictive and other conventions are in active use E.g.

https://github.com/apache/hbase/tree/master/hbase-protocol/src/main/protobuf

This is a clone of
aantono/gradle-plugin-protobuf#24
zhangkun83 added a commit that referenced this issue Apr 21, 2015
@zhangkun83
Allow custom proto source directories. Resolves #1
e49c439 
Create protoSources convention that can be used to override the default
proto file location, i.e., "src/main/proto" etc.
Create testProjectCustomProtoDir to test it.
@zhangkun83 zhangkun83 mentioned this issue Apr 21, 2015
Merged
zhangkun83 added a commit that referenced this issue Apr 21, 2015
@zhangkun83
Allow custom proto source directories. Resolves #1
6890bbd 
Create protoSources convention that can be used to override the default
proto file location, i.e., "src/main/proto" etc.
Create testProjectCustomProtoDir to test it.
zhangkun83 added a commit that referenced this issue Apr 24, 2015
@zhangkun83
Allow custom proto source directories. Resolves #1
bf20e08 
- Create protoSources convention that can be used to override the default
  proto file location, i.e., "src/main/proto" etc.
- Create testProjectCustomProtoDir to test it.
- Change the required Gradle version to 2.2
@zhangkun83 zhangkun83 mentioned this issue Apr 28, 2015
Merged
zhangkun83 added a commit that referenced this issue Apr 28, 2015
@zhangkun83
Add "proto" to sourceSets for customizing proto file locations.
c9cc55b 
Resolves #4, an alternative solution to #1.

Example:
sourceSets {
  main {
    proto {
      srcDir 'src/main/protobuf'
      include '**/*.protodevel'
    }
  }
}

Removed the protoSources convention that was used to do this.
podarsmarty pushed a commit to podarsmarty/protobuf-gradle-plugin that referenced this issue Jul 22, 2016
@betrisey @omkarmoghe
Trimming password to 15 characters (google#3)
715b0be 
as in the python project https://github.com/AHAAAAAAA/PokemonGo-Map/blob/master/example.py#L341

Fixes google#1
@mz4Mobile mz4Mobile mentioned this issue Nov 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom proto dir google/protobuf-gradle-plugin
1 participant
@louiscryan