Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .jar plugins #422

Closed
wants to merge 1 commit into from

Conversation

Scottmitch
Copy link

Motivation:
Proto only supports plugins as single file executables, and
protobuf-gradle-plugin follows the same pattern. This makes it difficult
to use a plugin that relies on a runtime (e.g. jvm).

Modifications:

  • If the plugin is a jar file, create a trampoline script as the protoc
    executable which executes the jar file

Result:
Fixes #168

@google-cla
Copy link

google-cla bot commented Jul 27, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Jul 27, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Motivation:
Proto only supports plugins as single file executables, and
protobuf-gradle-plugin follows the same pattern. This makes it difficult
to use a plugin that relies on a runtime (e.g. jvm).

Modifications:
- If the plugin is a jar file, create a trampoline script as the protoc
executable which executes the jar file

Result:
Fixes google#168
@google-cla
Copy link

google-cla bot commented Jul 27, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Scottmitch Scottmitch closed this Jul 27, 2020
@Scottmitch
Copy link
Author

re-opened under #423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling a pure Java plugin
1 participant