Emulate and deprecate generatedFilesBaseDir #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes google#33 for users not changing generatedFilesBaseDir. Stop documenting generatedFilesBaseDir since it produces poor results, but keep it functional with its existing Copy semantics. Fixes google#332
rougsig
reviewed
Nov 5, 2022
src/main/groovy/com/google/protobuf/gradle/ProtobufExtension.groovy
Outdated
Show resolved
Hide resolved
rougsig
reviewed
Nov 6, 2022
src/main/groovy/com/google/protobuf/gradle/GenerateProtoTask.groovy
Outdated
Show resolved
Hide resolved
Can't reference project from action
I don't know how to make this trigger a warning, for either Groovy and Kotlin. Both seem to ignore it.
YifeiZhuang
approved these changes
Nov 7, 2022
This fixes `class java.lang.Object cannot be cast to class com.google.protobuf.gradle.ProtobufPlugin` in "testProjectAndroid succeeds with configuration cache". The configuration cache is somehow confusing things, including defeating static typing. Redefining the variable locally avoids the reference to ProtobufPlugin.
rougsig
reviewed
Nov 7, 2022
src/main/groovy/com/google/protobuf/gradle/ProtobufExtension.groovy
Outdated
Show resolved
Hide resolved
Closed
rougsig
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33 for users not changing generatedFilesBaseDir. Stop documenting generatedFilesBaseDir since it produces poor results, but keep it functional with its existing Copy semantics. Fixes #332