-
Notifications
You must be signed in to change notification settings - Fork 183
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This catches issues like #630 where we forgot to use return value of `rebuild`. Since `rebuild` does not update in-place, not using the return value is often a bug. This adds `meta` as a dependency but it should not affect generated code. We may also want to use `meta` in the future for things like: - Annotating `GeneratedMessage` methods that are supposed to be used by the generated code with `@protected`. - Annotating generated message classes with `@sealed`. This help with maintaining backwards compatibility when adding new members to generated messages or to `GeneratedMessage`.
- Loading branch information
Showing
4 changed files
with
10 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters