improve the readability of the generated code #771
Comments
osa1
pushed a commit
that referenced
this issue
Nov 14, 2022
This improves the readability of the generated code (see #771 for context). - use shared consts to reduce the number of repeated bool.fromEnvironment() expressions (all the bool.fromEnvironment() expressions are gathered up while generated the file and written as consts at the end of the file) - turn on a few additional lints - update the changelog
Merged
|
@devoncarew we merged a few PRs about this, can this be closed as complete or do you have more changes planned? |
|
I think we're good to close this - any other things we notice wrt readability can just be tackled at the time / filed as separate issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi; I have some ideas for changes that could improve the readability of the generated code. These would all be non-functional changes; they wouldn't effect the compiled size of the code or the runtime performance.
The readability of the generated code probably isn't a critical consideration here, so I thought I'd open an issue to discuss before sending PRs. Some potential changes:
ncopies ofconst $core.bool.fromEnvironment('protobuf.omit_field_names')in the generated files into a single_omitFieldNamesconst in each filecc @osa1
The text was updated successfully, but these errors were encountered: