Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add // ignore_for_file: type=lint comments to the top of generated files #803

Open
jakemac53 opened this issue Feb 9, 2023 · 1 comment

Comments

@jakemac53
Copy link
Contributor

Today there are some lints that will trigger on protobuf files (such as the 80 char limit lint). The only real solution is to disable those lints entirely for the whole project.

However, this package could add // ignore_for_file: type=lint to the top of generated files so that lints are all silenced. In general for generated code this is a good practice, to eliminate noise.

@osa1
Copy link
Member

osa1 commented Jun 9, 2023

We should do this, but just type=lint won't be enough for now as it currently doesn't ignore all lints, see #833 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants