Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Policy violation Binary Artifacts #847

Closed
google-allstar-prod bot opened this issue Jun 16, 2023 · 3 comments · Fixed by #851
Closed

Security Policy violation Binary Artifacts #847

google-allstar-prod bot opened this issue Jun 16, 2023 · 3 comments · Fixed by #851
Labels

Comments

@google-allstar-prod
Copy link

This issue was automatically created by Allstar.

Security Policy Violation
Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

Artifacts Found

  • protoc_plugin/bin/protoc_plugin.exe

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.


Allstar has been installed on all Google managed GitHub orgs. Policies are gradually being rolled out and enforced by the GOSST and OSPO teams. Learn more at http://go/allstar

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

@osa1
Copy link
Member

osa1 commented Jun 16, 2023

This binary is for bin/protoc_plugin.dart. I retracted the latest release from pub.dev as the binary file made it into the tarball as well, and deleted the latest release from GitHub releases. I will rewrite the last two commits to remove the binary file and then release protoc_plugin-21.0.2. (same as 21.0.1, just without the binary file)

We should also add a .gitignore rule (and maybe even a hook) to avoid adding/pushing .exe files again in the future.

@google-allstar-prod
Copy link
Author

Updating issue after ping interval. See its status below.


Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

Artifacts Found

  • protoc_plugin/bin/protoc_plugin.exe

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.

1 similar comment
@google-allstar-prod
Copy link
Author

Updating issue after ping interval. See its status below.


Project is out of compliance with Binary Artifacts policy: binaries present in source code

Rule Description
Binary Artifacts are an increased security risk in your repository. Binary artifacts cannot be reviewed, allowing the introduction of possibly obsolete or maliciously subverted executables. For more information see the Security Scorecards Documentation for Binary Artifacts.

Remediation Steps
To remediate, remove the generated executable artifacts from the repository.

Artifacts Found

  • protoc_plugin/bin/protoc_plugin.exe

Additional Information
This policy is drawn from Security Scorecards, which is a tool that scores a project's adherence to security best practices. You may wish to run a Scorecards scan directly on this repository for more details.

@osa1 osa1 closed this as completed in #851 Jun 19, 2023
osa1 added a commit that referenced this issue Jun 19, 2023
Also bump version number as I've retracted the last release.

Fixes #847.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant