Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak BuilderInfo and FieldInfo docs: #597

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Tweak BuilderInfo and FieldInfo docs: #597

merged 2 commits into from
Apr 7, 2022

Conversation

osa1
Copy link
Member

@osa1 osa1 commented Apr 4, 2022

  • Fix documentation syntax, add references to other classes, properties,
    methods

  • Document undocumented properties

  • Remove references to non-existent identifiers

  • Some rewording

- Fix documentation syntax, add references to other classes, properties,
  methods

- Document undocumented properties

- Remove references to non-existent identifiers

- Some rewording
@osa1 osa1 requested a review from sigurdm April 4, 2022 19:31
Copy link
Collaborator

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osa1
Copy link
Member Author

osa1 commented Apr 5, 2022

@sigurdm addressed your comments. It would be great if you could proof read 😄

@osa1 osa1 requested a review from sigurdm April 7, 2022 13:25
Copy link
Collaborator

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osa1 osa1 merged commit b7f9569 into google:master Apr 7, 2022
@osa1 osa1 deleted the docs_1 branch April 7, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants