Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wrapped lists in PbList monomorphic #902

Merged
merged 6 commits into from
Nov 23, 2023

Commits on Nov 20, 2023

  1. Make wrapped lists/maps in PbList/PbMap monomorphic

    Use the same allocation syntax in all allocation sites to make sure one
    implementation class will flow into the fields.
    
    For `PbMap`, this doesn't make any difference, but makes the intention
    clear. Map calls are currently already monomorphic.
    
    For `PbList`, the list field becomes monomorphic growable list (from the
    list base class). This makes `add` calls monomorphic and inlinable, and
    avoids double mutability checks (once in `PbList.add`, again in
    `_wrappedList.add`).
    osa1 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    595c8ca View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Update

    osa1 committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    78e0e4b View commit details
    Browse the repository at this point in the history
  2. Update changelog

    osa1 committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    97c0bbe View commit details
    Browse the repository at this point in the history
  3. Rewording

    osa1 committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    b468d8f View commit details
    Browse the repository at this point in the history
  4. Update map unmodifiable

    osa1 committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    b61f89e View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Update comments

    osa1 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    f7584bd View commit details
    Browse the repository at this point in the history