Merge pull request #4903 from BSBandme/fix_js_build

fix commonjs js provide GOOGLE_CHECK
protocolbuffers · Jul 12, 2018 · f21d4d6 · f21d4d6
2 parents 84752ff + f42ddff
commit f21d4d6
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/google/protobuf/compiler/js/js_generator.cc b/src/google/protobuf/compiler/js/js_generator.cc
@@ -1681,7 +1681,7 @@ void Generator::GenerateProvides(const GeneratorOptions& options,
       if (options.import_style == GeneratorOptions::kImportCommonJsStrict) {
         string namespaceObject = *it;
         // Remove "proto." from the namespace object
-        GOOGLE_CHECK(namespaceObject.compare(0, 6, "proto."));
+        GOOGLE_CHECK(namespaceObject.compare(0, 6, "proto.") == 0);
         namespaceObject.erase(0, 6);
         printer->Print("goog.exportSymbol('$name$', null, proto);\n", "name",
                 namespaceObject);