Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra support for plugins doesn't support --[name]_opt without --plugin #2712

Closed
thomasvl opened this issue Feb 13, 2017 · 0 comments
Closed

Comments

@thomasvl
Copy link
Contributor

#2284 landed the support for --[name]_opt for plugins, but on apple/swift-protobuf#245 we realized it depends on --plugin having been used to tell the command line parsing about the plugin. Seems like it might be possible to have the --[name]-out also been enough to tell the parsing about the options argument. Only thing I'm not sure is if that would sill have an ordering issues in that would the --[name]_out have to come before --[name]_opt?

thomasvl added a commit to thomasvl/protobuf that referenced this issue Feb 13, 2017
--[name]_opt support depended on the plugin being register, and didn't support
working with just --[name]_out directive (where the plugin is found via the
users PATH. This extends the command line handing to allow --[name]_out to
be all it takes for the _opt directive to also be supported.

Fixes protocolbuffers#2712
thomasvl added a commit that referenced this issue Feb 14, 2017
--[name]_opt support depended on the plugin being register, and didn't support
working with just --[name]_out directive (where the plugin is found via the
users PATH. This extends the command line handing to allow --[name]_out to
be all it takes for the _opt directive to also be supported.

Fixes #2712
TeBoring pushed a commit that referenced this issue Feb 14, 2017
--[name]_opt support depended on the plugin being register, and didn't support
working with just --[name]_out directive (where the plugin is found via the
users PATH. This extends the command line handing to allow --[name]_out to
be all it takes for the _opt directive to also be supported.

Fixes #2712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants