Support extra parameters for plugins. #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvl
reviewed
Oct 26, 2016
| @@ -262,6 +262,10 @@ void AddDefaultProtoPaths(vector<pair<string, string> >* paths) { | |||
| return; | |||
| } | |||
| } | |||
|
|
|||
| string PluginName(const string& plugin_prefix, const string& directive) { | |||
There was a problem hiding this comment.
Maybe document that this assumes "--" on the front and "_out"/"_opt" on the end?
xfxyjwf
approved these changes
Oct 26, 2016
plaflamme
added a commit
to plaflamme/protoc-bridge
that referenced
this pull request
Jun 10, 2020
This feature was added in protocolbuffers/protobuf#2284 and allows options with `:` in the value.
thesamet
pushed a commit
to scalapb/protoc-bridge
that referenced
this pull request
Jun 11, 2020
* Use _opt parameter to pass plugin options. This feature was added in protocolbuffers/protobuf#2284 and allows options with `:` in the value. * Adds a test for passing parameters to plugins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.