Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #include in cc files #2471

Merged
merged 1 commit into from Dec 13, 2016

Conversation

jbrianceau
Copy link
Contributor

No description provided.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@jbrianceau
Copy link
Contributor Author

I'd like to push this change to make Chromium presubmit check happy (https://codereview.chromium.org/2495533002/)

@jbrianceau
Copy link
Contributor Author

Could you please take a look at this PR @xfxyjwf ?

@bazel-io
Copy link

Can one of the admins verify this patch?

@xfxyjwf xfxyjwf self-assigned this Dec 12, 2016
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Dec 12, 2016

I don't quite understand the reason for these changes. Could you elaborate? Why are some of them changed to brackets while others are still double-quoted?

@jbrianceau
Copy link
Contributor Author

I'd like to upgrade protobuf version in Chromium (https://codereview.chromium.org/2495533002/).
There is a presubmit rule in Chromium that does not allow quoted includes for google/* and hence I cannot upgrade to current master branch.
Maybe @acozzette would have more information about this, as this is similar to #2366

@xfxyjwf
Copy link
Contributor

xfxyjwf commented Dec 13, 2016

ok, so it seems most of protobuf code uses angle-brackets to include test .pb.h files. This change seems fine to me.

@xfxyjwf xfxyjwf merged commit eb455ce into protocolbuffers:master Dec 13, 2016
@jbrianceau
Copy link
Contributor Author

Thanks !

@jbrianceau jbrianceau deleted the fix-include-style branch December 21, 2016 21:26
bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants