-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #include in cc files #2471
Fix #include in cc files #2471
Conversation
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
I'd like to push this change to make Chromium presubmit check happy (https://codereview.chromium.org/2495533002/) |
Could you please take a look at this PR @xfxyjwf ? |
Can one of the admins verify this patch? |
I don't quite understand the reason for these changes. Could you elaborate? Why are some of them changed to brackets while others are still double-quoted? |
I'd like to upgrade protobuf version in Chromium (https://codereview.chromium.org/2495533002/). |
ok, so it seems most of protobuf code uses angle-brackets to include test .pb.h files. This change seems fine to me. |
Thanks ! |
…tyle Fix #include in cc files
No description provided.