Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Fix downloading binary images to device #153

Closed
wants to merge 3 commits into from
Closed

Conversation

penn5
Copy link

@penn5 penn5 commented Mar 27, 2019

BytesIO is used if no length is provided, so the correct type here is bytes. Also binary images are often flashed, and especially the Android bootimage header contains 0x80 which cannot be decoded in the default codec for 'r' type, which is default.

BytesIO is used if no length is provided, so the correct type here is bytes. Also binary images are often flashed, and especially the Android bootimage header contains 0x80 which cannot be decoded in the default codec for 'r' type, which is default.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.567% when pulling 633fe32 on penn5:patch-1 into d9b94b2 on google:master.

@penn5
Copy link
Author

penn5 commented Mar 27, 2019

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

data would already be bytes, so no encode available.
I'm writing a fuzzer so flashing empty files is a good feature. Normal fastboot supports it, so why not the python one?
@penn5 penn5 closed this Jul 22, 2019
@penn5 penn5 deleted the patch-1 branch July 22, 2019 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants