Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #300 typed arguments #320

Closed
wants to merge 11 commits into from
Closed

Fix #300 typed arguments #320

wants to merge 11 commits into from

Conversation

loynoir
Copy link

@loynoir loynoir commented Feb 16, 2021

Goal

[x] Solve issue300
[x] Let python-fire respect function's type annotations, and cast arguments into right types.
[x] Solve issue64

Status

  1. If exists annotation, simple type (str, int, float) arguments are casted correctly now.
  2. iln-sk add datetime and pathlib typed.
  3. completion zsh compactible.

Now support

def hello(self, x: str, y: int, z: float):
    assert type(x) == str
    assert type(y) == int
    assert type(z) == float

Not Support

Custom types in annotations.

@google-cla
Copy link

google-cla bot commented Feb 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Author has not signed CLA label Feb 16, 2021
@loynoir
Copy link
Author

loynoir commented Feb 18, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Author has signed CLA and removed cla: no Author has not signed CLA labels Feb 18, 2021
@google-cla
Copy link

google-cla bot commented Apr 12, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Author has not signed CLA and removed cla: yes Author has signed CLA labels Apr 12, 2021
@google-cla
Copy link

google-cla bot commented May 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

2. support RegExp type
3. Fix situation annotation might be `"str"`
2. Thus, increase max-line-length to 90
@google-cla
Copy link

google-cla bot commented May 14, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented May 14, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@baryluk
Copy link

baryluk commented Aug 16, 2021

This would be super useful. Right now we need to specify a lot of decorators to provide similar functionality, because very often our arguments looks like integers, and they are converted to int automagically, which triggers code later to fail (i.e. because it tries to use regexp on it, or concat with other string, etc).

Another good feature would be ability to disable automatic type detection also for kwargs, if it is typed, i.e. Dict[str, str].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Author has not signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants