Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pylint script to .travis.yml #38

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Adds pylint script to .travis.yml #38

merged 1 commit into from
Mar 28, 2017

Conversation

dbieber
Copy link
Member

@dbieber dbieber commented Mar 27, 2017

No description provided.

install:
- python setup.py develop
script: nosetests --ignore-files=parser_fuzz_test.py --exclude=test_components_py3.py
script:
- python -m pytest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay for pytest!

@jtratner
Copy link
Contributor

How would you feel about adding something like a Makefile so that people can run tests locally? I'm happy to put it up if you like.

I'm not sure how to replicate what you have on travis on my local machine tho (e.g., if I want to just run a test repeatedly or profile).

For example, running python -m pytest alone generates a ton of errors about other modules installed. (Whereas python -m pytest fire works quite well).

@dbieber dbieber merged commit 51fc990 into master Mar 28, 2017
@dbieber
Copy link
Member Author

dbieber commented Mar 28, 2017

I'd be open to something like that, though I'm skeptical that adding a Makefile is necessary.
Would simply changing the .travis.yml file to say python -m pytest fire be sufficient?

@dbieber dbieber deleted the copybara branch March 28, 2017 14:53
@dbieber dbieber mentioned this pull request Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants