Fix path to requirements.txt #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wondering how that the PR #431 went 🟢 |
|
Because it only ran the CLA check:
That was because the test workflow only triggered for on: [push]It failed on #428 because it fixes the triggers: on: [push, pull_request]So it also runs on upstream for the PR trigger. This is good, so we can see if PRs from forks pass on the CI. This is very important for open source, where people often contribute from forks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #431 to fix the CI.
Sample build: https://github.com/hugovk/python-fire/actions/runs/4068330039