WIP : Fix Part 1 of issue 51, uses os.path.basename(sys.argv[0])

[saurabhkpatel]

Need help for creating the test case for this change.

[dbieber]

To test a specific argv you can use mock.patch as shown here.
with mock.patch.object(sys, 'argv', ['progname']):

I would add the test to core_test.py, maybe as a second test after testFire named testFireDefaultName.
The test could use a filepath for sys.argv[0], include '--', '--trace' as args, and then do something like check that the basename shows up in the output.

Ideally there would be a way to test that name is being set appropriately, and then separately in trace_test we could test that the name is being used appropriately, but we don't have a good way to do the former.

[saurabhkpatel]

@dbieber thanks for your suggestions :)
Never used mock in the python but this is the opportunity to learn from the community :)

I would write a new test method in core_test.py. My thoughts are similar like this.

  def testFireDefaultName(self):
    with mock.patch.object(sys, 'argv',
                           ['/github/python-fire/fire/base_filename.py']):
      output = fire.Fire(tc.Empty)
     assertIn("base_filename.py", output)    # would it work? 

I am not sure how to gather print output as return of fire.Fire(tc.Empty).

Any suggestions?

[dbieber]

Once #54 is checked in you can use with self.assertOutputMatches to check the output of something like fire.Fire(tc.Empty). That should be checked in ~tomorrow.

[dbieber]

^^ #54 is checked in now

[dbieber]

Closing. Superseded by #59.