Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

bugfix - missing parameters in constructor #32

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

luca-vercelli
Copy link
Contributor

When the timeout expires, the TimeoutExpired exception is not built since parameters are wrong. A TypeError is thrown. As a (bad) consequence, program is not killed.
I see in Python 3.6.3 this has been fixed.

when the timeout expires, the TimeoutExpired exception is not built since parameters are wrong.
I see  in Python 3.6.3 this has been fixed.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@luca-vercelli
Copy link
Contributor Author

Just signed.

@googlebot
Copy link

CLAs look good, thanks!

@gpshead
Copy link
Contributor

gpshead commented Oct 19, 2017

For reference, this is in the Windows side of the code which is not really exercised of tested as that wasn't the original point of the backport. This fix is the same as that made in python/cpython@9a67e6c upstream.

@gpshead gpshead merged commit dabb9d8 into google:master Oct 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants