This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
Make it clear that nonly posix system are supported #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are the incompatibilities with Windows? I'm using it for the timeout capability and seems to be working fine for me at the moment. What am I missing? |
|
I'm not going to make it explicitly break on windows because the ship has already sailed and people are using it there. :) I made the backport specifically for the POSIX platform extension module. My point about being unsupported is that it is not being tested there. I will ultimately accept pull requests that fix issues on Windows but I do have to trust that people who sent them have tested that they work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.