-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Conv1D's weight info extraction #14
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Hi @Duchstf Thank you for working on this! Could you please write a test to catch the original error and with your PR that it can be passed? |
Hm ... I'm wondering what happened here? Why does it fail a test? |
No worries. It is inside our internal review system. I will let you know if anything need from your side. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. I will launch a internal review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi could you help me sync to the head again. there was a code change before merging this PR? thanks!
Merge with head
PiperOrigin-RevId: 293813781 Change-Id: Id4539ccc5b3e252c08b7df67b94bea04d2dd0382
PiperOrigin-RevId: 293813781 Change-Id: Id4539ccc5b3e252c08b7df67b94bea04d2dd0382
Hi,
This is a PR to fix the
print_qstats
error I mentioned in #13 . Essentially I just replacedkernel_h
andkernel_w
extraction bykernel_length
forConv1D
. Someone might have copied the code fromConv2D
and forgot to change it. I tested and it worked fine.Regards,
Duc.