Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Conv1D's weight info extraction #14

Merged
merged 4 commits into from
Feb 7, 2020
Merged

Conversation

Duchstf
Copy link
Contributor

@Duchstf Duchstf commented Feb 3, 2020

Hi,

This is a PR to fix the print_qstats error I mentioned in #13 . Essentially I just replaced kernel_h and kernel_w extraction by kernel_length for Conv1D. Someone might have copied the code from Conv2D and forgot to change it. I tested and it worked fine.

Regards,

Duc.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no contribution license agreement not-signed label Feb 3, 2020
@Duchstf
Copy link
Contributor Author

Duchstf commented Feb 3, 2020

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes contribution license agreement signed and removed cla: no contribution license agreement not-signed labels Feb 3, 2020
@zhuangh
Copy link
Contributor

zhuangh commented Feb 3, 2020

Hi @Duchstf

Thank you for working on this! Could you please write a test to catch the original error and with your PR that it can be passed?

@zhuangh zhuangh self-assigned this Feb 3, 2020
@zhuangh zhuangh self-requested a review February 3, 2020 19:57
@zhuangh zhuangh added the ready to pull to trigger copybara-service label Feb 3, 2020
@Duchstf
Copy link
Contributor Author

Duchstf commented Feb 4, 2020

Hm ... I'm wondering what happened here? Why does it fail a test?

@zhuangh
Copy link
Contributor

zhuangh commented Feb 4, 2020

Hm ... I'm wondering what happened here? Why does it fail a test?

No worries. It is inside our internal review system. I will let you know if anything need from your side. Thanks!

@zhuangh zhuangh removed the ready to pull to trigger copybara-service label Feb 5, 2020
Copy link
Contributor

@zhuangh zhuangh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. I will launch a internal review.

@zhuangh zhuangh added ready to pull to trigger copybara-service and removed ready to pull to trigger copybara-service labels Feb 5, 2020
@zhuangh zhuangh self-requested a review February 6, 2020 03:33
@zhuangh zhuangh removed the ready to pull to trigger copybara-service label Feb 6, 2020
Copy link
Contributor

@zhuangh zhuangh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi could you help me sync to the head again. there was a code change before merging this PR? thanks!

@zhuangh zhuangh added the ready to pull to trigger copybara-service label Feb 6, 2020
qkeras-robot pushed a commit that referenced this pull request Feb 7, 2020
PiperOrigin-RevId: 293813781
Change-Id: Id4539ccc5b3e252c08b7df67b94bea04d2dd0382
@qkeras-robot qkeras-robot merged commit f149ee3 into google:master Feb 7, 2020
jecorona97 pushed a commit to jecorona97/qkeras that referenced this pull request Jun 9, 2020
PiperOrigin-RevId: 293813781
Change-Id: Id4539ccc5b3e252c08b7df67b94bea04d2dd0382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes contribution license agreement signed ready to pull to trigger copybara-service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants