Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FakeTimer from docs and deprecate #134

Merged
merged 2 commits into from May 29, 2014

Conversation

yjbanov
Copy link
Member

@yjbanov yjbanov commented May 14, 2014

Because it's private

@seaneagan
Copy link
Contributor

See #124. FakeTimer is still there, and was introduced before #98.

@yjbanov
Copy link
Member Author

yjbanov commented May 15, 2014

Ah, good point. But if we want to deprecate it, maybe remove from docs anyway?

@cbracken
Copy link
Member

Agreed, but let's add the deprecation in this PR.

@yjbanov yjbanov changed the title Remove FakeTimer from docs Remove FakeTimer from docs and deprecate May 29, 2014
@yjbanov
Copy link
Member Author

yjbanov commented May 29, 2014

Deprecated and moved existing usage to the shiny new FakeAsync

@cbracken
Copy link
Member

lgtm

cbracken added a commit that referenced this pull request May 29, 2014
Remove FakeTimer from docs and deprecate
@cbracken cbracken merged commit acf36fa into google:master May 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants