add test for getting return type of a getter #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting the return type of a getter should be corrected by https://codereview.chromium.org/1311873004/. |
|
Should this test now be merged then? Either that or this issue can be closed if its tested elsewhere. |
|
whoops didn't mean to close :) |
|
I added material similar to your input to 'parameter_test.dart' (where other tests of explicitly declared getters and setters occur), and I also added tests on the return types of the already declared implicit getters and setters in 'implicit_getter_setter_test.dart', so it should be covered today. Thanks again for your input, it was indeed missing at that point! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently fails, but demonstrates the use case that polymer needs.