Use workaround for 198 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2020
sigurdm
approved these changes
Sep 28, 2020
|
Thanks! With this change, code generation for tests are again working (before the change, code could only be generated for one test at a time). There is no test which will run code generation, but this will be part of the change where we run the code generation via Travis. A PR for that is coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #198 reports an
InconsistentAnalysisExceptionwhen code generation is performed with more than one entry point. A workaround came up in dart-lang/build#2634, and this PR uses that workaround, which does eliminate the dynamic errors. Prepared to publish as version 2.2.6.