Separate guice

[sheepdreamofandroids]

This separates the schema logic from the guice modules.
SchemaBundle could get a bunch of utility methods to make it easy to programmatically define a schema.
A few more tests are needed though the existing tests already cover this code.

[siderakis]

Hello, thanks for the PR.

Can you please run the google-java-format formatter on this PR. (https://github.com/google/google-java-format)

If possible can you break the CL into a few smaller changes to make it easier to review.

[sheepdreamofandroids]

Of course I can use the formatter. Shall I add one of the maven plugins?

I can split the PR into two independent changes. Since I'm mostly moving code into other classes the diff will still be big even though the actual change is small.

[siderakis]

That sounds good!

…

Sent from my iPhone

On May 23, 2019, at 4:06 AM, Guus Bloemsma ***@***.***> wrote: Of course I can use the formatter. Shall I add one of the maven plugins? I can split the PR into two independent changes. Since I'm mostly moving code into other classes the diff will still be big even though the actual change is small. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[coveralls]

Pull Request Test Coverage Report for Build 295

• 246 of 329 (74.77%) changed or added relevant lines in 4 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.3%) to 44.186%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
rejoiner/src/main/java/com/google/api/graphql/rejoiner/SchemaBundle.java	11	29	37.93%
rejoiner/src/main/java/com/google/api/graphql/rejoiner/SchemaModule.java	7	29	24.14%
rejoiner/src/main/java/com/google/api/graphql/rejoiner/SchemaDefinitionReader.java	227	270	84.07%

Files with Coverage Reduction	New Missed Lines	%
rejoiner/src/main/java/com/google/api/graphql/rejoiner/SchemaModule.java	1	40.0%

Totals
Change from base Build 283:	-0.3%
Covered Lines:	893
Relevant Lines:	2021

---

💛 - Coveralls

[siderakis]

Thanks!

[sheepdreamofandroids]

Great! I was about to split this PR but this saves me some time ;-)