This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Add button to pre-download images to cache. Show when listed images are in cache. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nguyen-phillip
commented
Mar 23, 2018
nguyen-phillip
commented
- show green check next to cached images.
- show download button next to uncached images so that they can be downloaded before imaging.
- use blocks to handle sheet completion / cancel so that related code can stay together and to make chaining multiple actions together easier.
russellhancox
previously approved these changes
Mar 26, 2018
tburgin
reviewed
Mar 26, 2018
| @@ -20,6 +20,6 @@ | |||
| - (IBAction)continue:(id)sender; | |||
| - (IBAction)cancel:(id)sender; | |||
|
|
|||
| @property(readonly, nonatomic) BOOL shouldContinue; | |||
|
|
|||
| @property void (^completionBlock)(void); | |||
There was a problem hiding this comment.
block properties should be copy
| for (NSIndexPath *indexPath in self.collectionView.selectionIndexPaths) { | ||
| NSViewController *item = [self.collectionView itemAtIndexPath:indexPath]; | ||
| if (![item isKindOfClass:[CollectionViewItemAvailable class]]) continue; | ||
| CollectionViewItemAvailable *cvia = (CollectionViewItemAvailable *)item; |
There was a problem hiding this comment.
nit: consider a more descriptive variable name
There was a problem hiding this comment.
Removed the extra cvia variable entirely & made item into an NSCollectionViewItem *
|
PTAL |
tburgin
approved these changes
Mar 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.