Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the test test_get_tz_data_version in rust_icu_ucal #221

Closed
filmil opened this issue Nov 11, 2021 · 1 comment · Fixed by #222
Closed

Fix the test test_get_tz_data_version in rust_icu_ucal #221

filmil opened this issue Nov 11, 2021 · 1 comment · Fixed by #222

Comments

@filmil
Copy link
Member

filmil commented Nov 11, 2021

I get the following:

---- tests::test_get_tz_data_version stdout ----
thread 'tests::test_get_tz_data_version' panicked at 'version was: "2021a1"', rust_icu_ucal/src/lib.rs:394:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The regex used for tz data version matching trips up at the extra 1 at the end of 2021a1.
@filmil
Copy link
Member Author

filmil commented Nov 11, 2021

@kpozin FYI

filmil added a commit to filmil/rust_icu that referenced this issue Nov 11, 2021
@filmil
Adjust the time zone data regex
c872a47 
Starting from ICU 70, the time zone data version can have more than a
single letter after the release number. We used to have versions like
`2020a`, `2020b` etc.  With ICU 70, we get `2021a1`.

We're adopting the same regex as in:
https://fuchsia-review.googlesource.com/c/fuchsia/+/597898
for quick checks of the version string.

Fixes: google#221
@filmil filmil mentioned this issue Nov 11, 2021
Merged
filmil added a commit to filmil/rust_icu that referenced this issue Nov 11, 2021
@filmil
Adjust the time zone data regex
3e5cfed 
Starting from ICU 70, the time zone data version can have more than a
single letter after the release number. We used to have versions like
`2020a`, `2020b` etc.  With ICU 70, we get `2021a1`.

We're adopting the same regex as in:
https://fuchsia-review.googlesource.com/c/fuchsia/+/597898
for quick checks of the version string.

Fixes: google#221
filmil added a commit that referenced this issue Nov 11, 2021
@filmil
Adjust the time zone data regex
9a33dc1 
Starting from ICU 70, the time zone data version can have more than a
single letter after the release number. We used to have versions like
`2020a`, `2020b` etc.  With ICU 70, we get `2021a1`.

We're adopting the same regex as in:
https://fuchsia-review.googlesource.com/c/fuchsia/+/597898
for quick checks of the version string.

Fixes: #221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust the time zone data regex filmil/rust_icu
1 participant
@filmil