Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make feature=icu_config robust in face of version updates #23

Closed
filmil opened this issue Jan 2, 2020 · 0 comments · Fixed by #27
Closed

Make feature=icu_config robust in face of version updates #23

filmil opened this issue Jan 2, 2020 · 0 comments · Fixed by #27

Comments

@filmil
Copy link
Member

filmil commented Jan 2, 2020

When icu_config feature is turned off, there is no way for the code to detect the ICU library version in use, so at the moment it always defaults to 64. Which, of course, will be incorrect in the general case.

Add a way for the user to pass the desired ICU renaming version.
filmil added a commit to filmil/rust_icu that referenced this issue Jan 6, 2020
@filmil
Support non-generated versioned builds.
d38f135 
Adds the ability to build bindings for a user-defined
ICU library version, and to turn off build feature detection.

Since there are already plenty of configurations that one could
build the library in, I don't expect this to be the last fixup here.
But we got to start from somewhere.

Bumps the version to 0.0.4.

Fixes google#23
@filmil filmil mentioned this issue Jan 6, 2020
Merged
filmil added a commit to filmil/rust_icu that referenced this issue Jan 6, 2020
@filmil
Support non-generated versioned builds.
5b1efed 
Adds the ability to build bindings for a user-defined
ICU library version, and to turn off build feature detection.

Since there are already plenty of configurations that one could
build the library in, I don't expect this to be the last fixup here.
But we got to start from somewhere.

Bumps the version to 0.0.4.

Fixes google#23
filmil added a commit to filmil/rust_icu that referenced this issue Jan 6, 2020
@filmil
Support non-generated versioned builds.
843964d 
Adds the ability to build bindings for a user-defined
ICU library version, and to turn off build feature detection.

Since there are already plenty of configurations that one could
build the library in, I don't expect this to be the last fixup here.
But we got to start from somewhere.

Bumps the version to 0.0.4.

Fixes google#23
@filmil filmil closed this as completed in #27 Jan 7, 2020
filmil added a commit that referenced this issue Jan 7, 2020
@filmil
Support non-generated versioned builds. (#27)
dfb457f 
Adds the ability to build bindings for a user-defined
ICU library version, and to turn off build feature detection.

Since there are already plenty of configurations that one could
build the library in, I don't expect this to be the last fixup here.
But we got to start from somewhere.

Bumps the version to 0.0.4.

Fixes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support non-generated versioned builds filmil/rust_icu
1 participant
@filmil