Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU 67.1 brings in new C fallback method in the API #59

Closed
filmil opened this issue Mar 25, 2020 · 4 comments
Closed

ICU 67.1 brings in new C fallback method in the API #59

filmil opened this issue Mar 25, 2020 · 4 comments
Assignees
@kpozin
Labels
bug Something isn't working

Comments

@filmil
Copy link
Member

filmil commented Mar 25, 2020

Between 66.0.1 and 67.1 there was a change in how locale fallback works in the ICU4C API, which fixed a long-standing bug
with the library: https://unicode-org.atlassian.net/browse/ICU-20931

Now that the bug is fixed, our language matching tests no longer work, we should fix that.

---- tests::test_accept_language_exact_match stdout ----
thread 'tests::test_accept_language_exact_match' panicked at 'assertion failed: `(left == right)`
  left: `(Some(ULoc { repr: "es_MX" }), ULOC_ACCEPT_FALLBACK)`,
 right: `(Some(ULoc { repr: "ar_EG" }), ULOC_ACCEPT_VALID)`', rust_icu_uloc/src/lib.rs:774:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@filmil
Copy link
Member Author

filmil commented Mar 25, 2020

@kpozin something for you?

@kpozin kpozin self-assigned this Mar 25, 2020
@filmil
Copy link
Member Author

filmil commented Mar 25, 2020 •
edited

Note that 67.1 is not yet released. Perhaps we should just modify our developer instructions to check out ICU not-at-master?

@filmil
Copy link
Member Author

filmil commented May 8, 2020

Looks like 67.1 is released.

filmil added a commit to filmil/rust_icu that referenced this issue May 8, 2020
@filmil
Fixes broken test behaviors on old and new ICUs
4b8cf84 
With the following changes, we should be well positioned to tackle
ICU 67.1

- ICU4C correctly implements language fallbacks starting version 67.1,
  added two flavors of the same test, one for ICU versions 67 and
  onwards, and another for older versions.  Feature:
  `icu_version_67_plus`.  This happens in issue google#59.
- ICU4C version 63 has wrong result for a certain test, possibly due to
  the CLDR version on my machine, so test failed.  Turned that test off
  for versions less than 64.  This happens on my machine only, when the
  system ICU is used.
This was referenced May 8, 2020
Merged
Closed
@filmil filmil added the bug Something isn't working label May 8, 2020
filmil added a commit that referenced this issue May 8, 2020
@filmil
Fixes broken test behaviors on old and new ICUs
de07929 
With the following changes, we should be well positioned to tackle
ICU 67.1

- ICU4C correctly implements language fallbacks starting version 67.1,
  added two flavors of the same test, one for ICU versions 67 and
  onwards, and another for older versions.  Feature:
  `icu_version_67_plus`.  This happens in issue #59.
- ICU4C version 63 has wrong result for a certain test, possibly due to
  the CLDR version on my machine, so test failed.  Turned that test off
  for versions less than 64.  This happens on my machine only, when the
  system ICU is used.
@filmil
Copy link
Member Author

filmil commented May 13, 2020

FYI this is now fixed with #76

@filmil filmil closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpozin kpozin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@filmil @kpozin