Adds feature testing to ICU 63 and 64 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmil
force-pushed
the
add-64-build
branch
2 times, most recently
from
82547ef
to
742819c
Compare
filmil
force-pushed
the
add-64-build
branch
2 times, most recently
from
62ea57d
to
66c524c
Compare
Feature testing is needed to ensure that older generated code supports newly added `rust_icu_*` crates. - Ran `make static-bindgen` to refresh the bindings for all supported ICU versions. - Added ICU versions 63 and 64 to the feature testing matrix. - Generated lib_63.rs, lib_64.rs and symlinked lib.rs to it in rust_icu_sys. This makes the bindgen generated code uniform across versions. Fixes: 111
|
Note @kpozin, most of the bulk of this change is version uprev. |
kpozin
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature testing is needed to ensure that older generated code supports
newly added
rust_icu_*crates.Fixes: 111