Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fake s2av2 service layer #30

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fake s2av2 service layer #30

merged 1 commit into from
Jun 9, 2022

Conversation

rmehta19
Copy link
Collaborator

@rmehta19 rmehta19 commented Jun 7, 2022 •
edited

Implementing a Fake S2Av2 Service Layer. Implemented the getTlsConfiguration function.

@rmehta19 rmehta19 self-assigned this Jun 7, 2022
@rmehta19 rmehta19 changed the title Fake s2av2 service layer [WIP] Fake s2av2 service layer Jun 7, 2022
@rmehta19
Copy link
Collaborator Author

rmehta19 commented Jun 8, 2022

Fake Service running using bazel run:
image

@rmehta19
Copy link
Collaborator Author

rmehta19 commented Jun 8, 2022

This PR implements the SetUpSession RPC and also GetTlsConfiguration(called from switch in SetUpSession). The remaining 3 RPCs to be faked are commented in the switch as well. There is also a fake s2av2 service implementation.

@rmehta19 rmehta19 changed the title [WIP] Fake s2av2 service layer Fake s2av2 service layer Jun 8, 2022
@rmehta19 rmehta19 marked this pull request as ready for review June 8, 2022 01:30
matthewstevenson88
matthewstevenson88 reviewed Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Riya!

internal/v2/fake_s2av2/BUILD Outdated Show resolved Hide resolved
internal/v2/fake_s2av2/BUILD Outdated Show resolved Hide resolved
internal/v2/fake_s2av2/fake_s2av2.go Outdated Show resolved Hide resolved
internal/v2/fake_s2av2/fake_s2av2.go Outdated Show resolved Hide resolved
internal/v2/fake_s2av2/fake_s2av2.go Outdated Show resolved Hide resolved
internal/v2/fake_s2av2_service/BUILD Outdated Show resolved Hide resolved
internal/v2/fake_s2av2_service/fake_s2av2_service.go Outdated Show resolved Hide resolved
internal/v2/fake_s2av2_service/fake_s2av2_service.go Outdated Show resolved Hide resolved
internal/v2/fake_s2av2_service/fake_s2av2_service.go Outdated Show resolved Hide resolved
internal/v2/fake_s2av2/fake_s2av2_test.go Outdated Show resolved Hide resolved
matthewstevenson88
matthewstevenson88 reviewed Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Riya! The PR generally looks good, just a handful of minor comments. :)

internal/v2/fakes2av2/fakes2av2.go Outdated Show resolved Hide resolved
internal/v2/fakes2av2/fakes2av2.go Outdated Show resolved Hide resolved
internal/v2/fakes2av2/fakes2av2.go Outdated Show resolved Hide resolved
internal/v2/fakes2av2/fakes2av2_test.go Outdated Show resolved Hide resolved
internal/v2/fakes2av2/fakes2av2_test.go Outdated Show resolved Hide resolved
internal/v2/fakes2av2/fakes2av2_test.go Show resolved Hide resolved
internal/v2/fakes2av2/fakes2av2_test.go Outdated Show resolved Hide resolved
internal/v2/fakes2av2/fakes2av2_test.go Outdated Show resolved Hide resolved
internal/v2/fakes2av2/fakes2av2_test.go Outdated Show resolved Hide resolved
internal/v2/fakes2av2/fakes2av2_test.go Outdated Show resolved Hide resolved
@rmehta19 rmehta19 merged commit 89e096b into main Jun 9, 2022
This was referenced Jun 9, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewstevenson88 matthewstevenson88 matthewstevenson88 approved these changes

@tavishvaidya tavishvaidya Awaiting requested review from tavishvaidya

Assignees

@rmehta19 rmehta19

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmehta19 @matthewstevenson88