Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS Config Store makes calls to Fake S2A Service #31

Merged
merged 7 commits into from
Jun 13, 2022

Conversation

rmehta19
Copy link
Collaborator

@rmehta19 rmehta19 commented Jun 8, 2022

In this PR:
-TLS Config Store modified to call S2Av2 for Client TLS Configuration and Server TLS Configuration.
-Test suite modified to start / stop fake S2Av2 Server on port 8008.
-Cleaned up some error messages to be more clear.
-Removed fakes2av2_server binary(accidentally added through running go build in previous PR)

@rmehta19 rmehta19 self-assigned this Jun 8, 2022
@rmehta19 rmehta19 marked this pull request as ready for review June 9, 2022 22:56
@rmehta19 rmehta19 changed the title [WIP] TLS Config Store makes calls to Fake S2A Service TLS Config Store makes calls to Fake S2A Service Jun 9, 2022
Copy link
Collaborator

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Riya! I did a quick first pass. PTAL. :)

internal/v2/tls_config_store/tls_config_store.go Outdated Show resolved Hide resolved
internal/v2/tls_config_store/tls_config_store.go Outdated Show resolved Hide resolved
internal/v2/tls_config_store/tls_config_store.go Outdated Show resolved Hide resolved
@rmehta19
Copy link
Collaborator Author

Thanks for the comments Matt!

Copy link
Collaborator

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Riya! Here's another batch of comments. :)

internal/v2/s2av2.go Outdated Show resolved Hide resolved
internal/v2/s2av2.go Outdated Show resolved Hide resolved
internal/v2/s2av2.go Outdated Show resolved Hide resolved
internal/v2/s2av2.go Outdated Show resolved Hide resolved
internal/v2/s2av2.go Outdated Show resolved Hide resolved
internal/v2/tls_config_store/tls_config_store.go Outdated Show resolved Hide resolved
internal/v2/tls_config_store/tls_config_store.go Outdated Show resolved Hide resolved
internal/v2/tls_config_store/tls_config_store.go Outdated Show resolved Hide resolved
internal/v2/tls_config_store/tls_config_store.go Outdated Show resolved Hide resolved
@rmehta19
Copy link
Collaborator Author

Testing s2av2 with Logging

bazel run server (running go Echo server)
image

bazel run fakes2av2_server
image

bazel run client
image

@rmehta19
Copy link
Collaborator Author

rmehta19 commented Jun 11, 2022

Also, to summarize what ports are being used :

8080 for the go echo server
8008 for the fakes2av2 server
all the unit tests that start up fakes2av2 use :0 for the port

@rmehta19
Copy link
Collaborator Author

Testing s2av2 "without" Logging(retained the minimal amount of logging in the testonly code pre-This PR)

bazel run server (running go Echo server):
image

bazel run fakes2av2_server:
image

bazel run client:
image

internal/v2/s2av2.go Outdated Show resolved Hide resolved
internal/v2/s2av2_test.go Outdated Show resolved Hide resolved
internal/v2/tls_config_store/tls_config_store.go Outdated Show resolved Hide resolved
internal/v2/tls_config_store/tls_config_store.go Outdated Show resolved Hide resolved
internal/v2/tls_config_store/tls_config_store.go Outdated Show resolved Hide resolved
internal/v2/tls_config_store/tls_config_store_test.go Outdated Show resolved Hide resolved
@rmehta19
Copy link
Collaborator Author

Thanks for all the comments Matt! I made the changes and also started everything up again to verify it all works

Copy link
Collaborator

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple minor comments. Thanks for the great PR Riya! This PR was probably the most complex part of the whole project, so really great work getting it done.

@rmehta19
Copy link
Collaborator Author

Thanks Matt! I really appreciate all the helpful comments :)

@rmehta19 rmehta19 merged commit 8a6ca8a into main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants