-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS Config Store makes calls to Fake S2A Service #31
Conversation
8229b31
to
2218a79
Compare
8e4f2ae
to
443355f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Riya! I did a quick first pass. PTAL. :)
Thanks for the comments Matt! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Riya! Here's another batch of comments. :)
Also, to summarize what ports are being used : 8080 for the go echo server |
Thanks for all the comments Matt! I made the changes and also started everything up again to verify it all works |
3ac0567
to
9fe44a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple minor comments. Thanks for the great PR Riya! This PR was probably the most complex part of the whole project, so really great work getting it done.
Thanks Matt! I really appreciate all the helpful comments :) |
In this PR:
-TLS Config Store modified to call S2Av2 for Client TLS Configuration and Server TLS Configuration.
-Test suite modified to start / stop fake S2Av2 Server on port 8008.
-Cleaned up some error messages to be more clear.
-Removed fakes2av2_server binary(accidentally added through running go build in previous PR)