Allow already have abseil #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems minor enough to be fine. Abseil should probably support this workflow upstream too. Wish CMake made this easier. |
|
Thanks! |
jmr
reviewed
Dec 1, 2022
| @@ -68,7 +68,9 @@ if (WITH_GFLAGS) | |||
| add_definitions(-DS2_USE_GFLAGS) | |||
| endif() | |||
|
|
|||
| find_package(absl REQUIRED) | |||
| if (NOT TARGET absl::base) | |||
There was a problem hiding this comment.
If I just saw this code without having seen the PR, I would have no idea what it's doing or why.
Could you add a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't install abseil, we use add_subdirectory. so for us I needs patch like this.
Is it ok for you? The main idea if we already have abseil targets we don't need to find them