Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expression Keywords fail #57

Closed
nyplayer opened this issue Nov 28, 2015 · 5 comments
Closed

Regular expression Keywords fail #57

nyplayer opened this issue Nov 28, 2015 · 5 comments

Comments

@nyplayer
Copy link

This works on SageTV7 but does not work on SageTV9. I am finding out the Sage9 is more limited in the way you can define favorites than Sage7. They all worked fine in Sagetv7. I was wondering why some shows were not recording. It appears that SageTV9 does not handle regular expressions as good as SageTV7.

examples do not work.
keyword christmas "MV\d+"

Title Criminal Minds
keyword "EP\d+"
also
Category Docudrama
keyword "MV\d+"

@Narflex
Copy link
Member

Narflex commented Nov 28, 2015

I'll make a fix for this. It'll just require a setting to have it work the
legacy way which is slower and bypasses Lucene for search.

Jeff Kardatzke
Sent from my Android
On Nov 28, 2015 4:37 PM, "nyplayer" notifications@github.com wrote:

This works on SageTV7 but does not work on SageTV9. I am finding out the
Sage9 is more limited in the way you can define favorites than Sage7. They
all worked fine in Sagetv7. I was wondering why some shows were not
recording. It appears that SageTV9 does not handle regular expressions as
good as SageTV7.

examples do not work.
keyword christmas "MV\d+"

Title Criminal Minds
keyword "EP\d+"
also
Category Docudrama
keyword "MV\d+"


Reply to this email directly or view it on GitHub
#57.

@CraziFuzzy
Copy link
Contributor

Does lucene not support regex searches?

@stuckless
Copy link
Collaborator

Lucene does not support regex searches, but it does support many other complex searches and wildcard searches.

https://lucene.apache.org/core/2_9_4/queryparsersyntax.html

Regex is basically a poor man's search engine... it works, but, not the most efficient way to search large collections.

@CraziFuzzy
Copy link
Contributor

is this of any help?

https://lucene.apache.org/core/3_0_3/api/contrib-regex/org/apache/lucene/search/regex/RegexQuery.html

I understand regex is far less efficient, but efficiency is hardly important for this part of the code, and maximum customizibility of the filters/queries would be more important.

@Narflex
Copy link
Member

Narflex commented Dec 1, 2015

I've submitted a change that fixes this and it is set that way by default. :)

@Narflex Narflex closed this as completed Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants