Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gradle to support cross platform building the Sage.jar #8

Merged
merged 2 commits into from
Aug 13, 2015

Conversation

stuckless
Copy link
Collaborator

Eventually I'll add direct support for the other pieces as well.

See the BUILDING.md file information on how to use gradle, but the quick guide is basically just run ./gradlew or gradlew.bat and it will compile and build the Sage.jar

I'll add direct support for the other pieces as well)
@stuckless
Copy link
Collaborator Author

The conflict is on the .gitignore file... my changes are pretty small, so it should be an easy merge.

@Narflex
Copy link
Member

Narflex commented Aug 13, 2015

Can't you just rebase. :) Then I can click the magic button rather than having to go through the whole command line process.

@stuckless
Copy link
Collaborator Author

Ok... I'll rebase :) But, as for the MiniClient... that's my next goal is to create a sageMiniClient jar and compare with you miniclient jar. For now, this is attempting to mimic the build of the server Sage.jar as per the buildsage.sh script.

@stuckless
Copy link
Collaborator Author

Ok, you should be ok to merge.

@Narflex
Copy link
Member

Narflex commented Aug 13, 2015

Thanks....do you happen to know if there's an easy way in GitHub to see the diff for the full set of changes being merged? It's annoying to have to look through them all independently (and the merges, rebases, etc.) I'd like to see one clean diff for what's being changed. :)

Narflex added a commit that referenced this pull request Aug 13, 2015
Added gradle to support cross platform building the Sage.jar
@Narflex Narflex merged commit 7069706 into google:master Aug 13, 2015
@Narflex
Copy link
Member

Narflex commented Aug 13, 2015

Nevermind the question...I just found the 'Files Changed' tab which gives me what I was looking for. :)

@Narflex
Copy link
Member

Narflex commented Aug 14, 2015

Don't forget to add yourself to the CONTRIBUTORS and AUTHORS files. :)

Narflex pushed a commit that referenced this pull request Sep 19, 2016
JREkiwi pushed a commit to JREkiwi/sagetv that referenced this pull request Dec 30, 2018
Added gradle to support cross platform building the Sage.jar
JREkiwi pushed a commit to JREkiwi/sagetv that referenced this pull request Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants