Fix style comments from review

google · Nov 1, 2021 · 04328c3 · 04328c3
1 parent 5a222e2
commit 04328c3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/Source/common/SNTConfigurator.h b/Source/common/SNTConfigurator.h
@@ -269,7 +269,7 @@
 @property(nonatomic) BOOL syncCleanRequired;
 
 ///
-/// USB Mass Storage Blocking. Defalts to false.
+/// USB Mass Storage Blocking. Defaults to false.
 ///
 @property(nonatomic) BOOL blockUSBMassStorage;
 

diff --git a/Source/common/SNTConfigurator.m b/Source/common/SNTConfigurator.m
@@ -91,7 +91,7 @@ @implementation SNTConfigurator
 static NSString *const kFCMProject = @"FCMProject";
 static NSString *const kFCMEntity = @"FCMEntity";
 static NSString *const kFCMAPIKey = @"FCMAPIKey";
-static NSString *const kBlockUSBMassStorageKey = @"blockUSBMassStorage";
+static NSString *const kBlockUSBMassStorageKey = @"BlockUSBMassStorage";
 
 // The keys managed by a sync server or mobileconfig.
 static NSString *const kClientModeKey = @"ClientMode";
@@ -568,10 +568,6 @@ - (void)setSyncCleanRequired:(BOOL)syncCleanRequired {
   [self updateSyncStateForKey:kSyncCleanRequired value:@(syncCleanRequired)];
 }
 
-- (void)setBlockUSBMassStorage:(BOOL)enabled {
-  [self updateSyncStateForKey:kBlockUSBMassStorageKey value:@(enabled)];
-}
-
 - (NSString *)machineOwner {
   NSString *machineOwner = self.configState[kMachineOwnerKey];
   if (machineOwner) return machineOwner;
@@ -667,6 +663,10 @@ - (BOOL)fcmEnabled {
   return (self.fcmProject.length && self.fcmEntity.length && self.fcmAPIKey.length);
 }
 
+- (void)setBlockUSBMassStorage:(BOOL)enabled {
+  [self updateSyncStateForKey:kBlockUSBMassStorageKey value:@(enabled)];
+}
+
 - (BOOL)blockUSBMassStorage {
   NSNumber *number = self.configState[kBlockUSBMassStorageKey];
   return number ? [number boolValue] : NO;

diff --git a/Source/santad/EventProviders/SNTEndpointSecurityManager.mm b/Source/santad/EventProviders/SNTEndpointSecurityManager.mm
@@ -375,7 +375,6 @@ - (void)messageHandler:(es_message_t *)m API_AVAILABLE(macos(10.15)) {
       BOOL isUSB = [diskInfo[@"DADeviceProtocol"] isEqualTo:@"USB"];
 
       if (!isRemovable || !isUSB) {
-        LOGI(@"Did not block mounting %s", m->event.mount.statfs->f_mntfromname);
         es_respond_auth_result(self.client, m, ES_AUTH_RESULT_ALLOW, false);
         return;
       }