Added tests for nil/NULL errors.

google · Sep 22, 2021 · 6a9be5d · 6a9be5d
1 parent 1c81d62
commit 6a9be5d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/Source/santametricservice/Formats/SNTMetricRawJSONFormatTest.m b/Source/santametricservice/Formats/SNTMetricRawJSONFormatTest.m
@@ -149,4 +149,11 @@ - (void)testMetricsConversionToJSON {
   XCTAssertEqualObjects(expectedJSONDict, jsonDict, @"generated JSON does not match golden file.");
 }
 
+- (void)testPassingANilOrNullErrorDoesNotCrash {
+  SNTMetricRawJSONFormat *formatter = [[SNTMetricRawJSONFormat alloc] init];
+
+  NSArray<NSData *> *output = [formatter convert:validMetricsDict error:nil];
+  output = [formatter convert:validMetricsDict error:NULL];
+}
+
 @end
diff --git a/Source/santametricservice/Writers/SNTMetricFileWriterTest.m b/Source/santametricservice/Writers/SNTMetricFileWriterTest.m
@@ -89,4 +89,18 @@ - (void)testWritingDataToFileWorks {
   testFileContents = [NSData dataWithContentsOfFile:url.path];
   XCTAssertEqualObjects(expected, testFileContents);
 }
+
+- (void)testThatPassingANilOrNullErrorDoesNotCrash {
+  NSString *testFile = [NSString pathWithComponents:@[ @"file://", self.tempDir, @"test.data" ]];
+  NSURL *url = [NSURL URLWithString:testFile];
+
+  SNTMetricFileWriter *fileWriter = [[SNTMetricFileWriter alloc] init];
+
+  NSData *firstLine = [@"AAAAAAAA" dataUsingEncoding:NSUTF8StringEncoding];
+
+  BOOL success = [fileWriter write:@[ firstLine ] toURL:url error:nil];
+  XCTAssertTrue(success);
+  success = [fileWriter write:@[ firstLine ] toURL:url error:NULL];
+  XCTAssertTrue(success);
+}
 @end