New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cached sizes when serializing #1028

Merged

mlw merged 2 commits into google:main from mlw:proto-calc-size-once

Jan 30, 2023

Member

mlw commented Jan 30, 2023

SerializeToArray was doing an extra call to ByteSizeLong, but we already had calculated this size when constructing the vector.


          Use cached sizes when serializing

3b7e596

mlw requested review from russellhancox, pmarkowsky, tburgin and kallsyms

January 30, 2023 20:22

mlw requested a review from a team as a code owner

January 30, 2023 20:22

russellhancox approved these changes

View reviewed changes


          Merge branch 'main' into proto-calc-size-once

84903ef

mlw merged commit 3acf3c1 into google:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment