Wire up TTYWriter instance to the file access client #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellhancox
approved these changes
Jul 25, 2023
mlw
force-pushed
the
fsmon-ttywriter-setup
branch
from
9dff709
to
3c9517c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: This PR is only a piece of the overall work to begin supporting user-facing messages when file access operations are denied in order to provide a better experience to users who violate policies. No actual user facing dialogs are presented yet, all deny operations are silent.
This PR only intends to wire up the TTY writer into the file access client. It is not currently put to use to keep this PR smaller.