Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: Add SyncExtraHeaders config option. #1144

Merged
merged 2 commits into from Aug 4, 2023
Merged

sync: Add SyncExtraHeaders config option. #1144

merged 2 commits into from Aug 4, 2023

Conversation

russellhancox
Copy link
Collaborator

Fixes #1143

@russellhancox russellhancox added enhancement sync service Issues related to the sync service / protocol labels Aug 3, 2023
@russellhancox russellhancox added this to the 2023.7 Release milestone Aug 3, 2023
@russellhancox russellhancox marked this pull request as ready for review August 4, 2023 01:12
@russellhancox russellhancox requested a review from a team as a code owner August 4, 2023 01:12
pmarkowsky
pmarkowsky reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just have the one typo. This should make it easy to include bearer tokens if so desired from MDM.

Source/common/SNTConfigurator.h Outdated Show resolved Hide resolved
@russellhancox @pmarkowsky
Update Source/common/SNTConfigurator.h
67f1e43 
Co-authored-by: Pete Markowsky <pmarkowsky@users.noreply.github.com>
@russellhancox russellhancox enabled auto-merge (squash) August 4, 2023 02:51
pmarkowsky
pmarkowsky approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@russellhancox russellhancox merged commit aaa0d40 into google:main Aug 4, 2023
9 checks passed
@russellhancox russellhancox deleted the sync-addl-headers branch August 4, 2023 03:17
p-harrison added a commit to p-harrison/santa that referenced this pull request Aug 28, 2023
@p-harrison
Document SyncExtraHeaders in configuration.md
497d66d 
Document the SyncExtraHeaders configuration option added in google#1144
@p-harrison p-harrison mentioned this pull request Aug 28, 2023
Merged
mlw pushed a commit that referenced this pull request Aug 28, 2023
@p-harrison
Document SyncExtraHeaders in configuration.md (#1166)
cae3578 
Document the SyncExtraHeaders configuration option added in #1144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarkowsky pmarkowsky pmarkowsky approved these changes

Assignees
No one assigned
Labels
enhancement sync service Issues related to the sync service / protocol
Projects
None yet
Milestone
2023.7 Release
Development

Successfully merging this pull request may close these issues.

Config: Add ability to include custom headers in sync requests
2 participants
@russellhancox @pmarkowsky